fix(dashboard): new created chart did not have high lighted effect when using the permalink of chart share in dashboard #20411
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en using the permalink of chart share in dashboard
Codecov Report
@@ Coverage Diff @@
## master #20411 +/- ##
==========================================
- Coverage 66.70% 66.70% -0.01%
==========================================
Files 1739 1739
Lines 65135 65139 +4
Branches 6897 6897
==========================================
Hits 43450 43450
- Misses 19932 19936 +4
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://34.209.17.2:8080. Credentials are |
stephenLYZ
approved these changes
Jun 18, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If we create a new chart and add it to the dashboard, then generating a permalink for that char from said dashboard does not highlight it on load.
The issue is that, for these charts, they're not part of the dashboard per-se, and get added at the end (in new rows).
For that reason, we're generating the id for them on the fly, and thus, they're always different on load.
The permalink does not find the chart in question in that case.
This PR changes the id generation for these charts to always be the same.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-06-16.at.14.55.04.mov
After:
new.mov
TESTING INSTRUCTIONS
Ensure that the chart highlights.
ADDITIONAL INFORMATION